From 88cddc0fe56a7d23570ce108bcf3f02e446edd59 Mon Sep 17 00:00:00 2001 From: Konrad Mrożek <kmrozek@comscore.com> Date: Thu, 31 Aug 2023 10:20:02 +0000 Subject: [PATCH] Treat malli errors as exceptions --- clojure/src/test_runner.clj | 28 +++++++++++++++++----------- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git a/clojure/src/test_runner.clj b/clojure/src/test_runner.clj index 57864bc..53ee877 100644 --- a/clojure/src/test_runner.clj +++ b/clojure/src/test_runner.clj @@ -21,14 +21,14 @@ (defmethod vim-report :fail [m] - (t/with-test-out - (when-let [source-file (some-> t/*testing-vars* - first - meta - :file)] - (println (str "FAIL:" source-file ":" (:line m) ":" (t/testing-vars-str m) ":" (t/testing-contexts-str) ":" (:message m "FAIL"))) - (println (str "FAIL-CONTINUE:EXPECTED:" (pr-str (:expected m)))) - (println (str "FAIL-CONTINUE:ACTUAL:" (pr-str (:actual m))))))) + (t/inc-report-counter :fail) + (when-let [source-file (some-> t/*testing-vars* + first + meta + :file)] + (println (str "FAIL:" source-file ":" (:line m) ":" (t/testing-vars-str m) ":" (t/testing-contexts-str) ":" (:message m "FAIL"))) + (println (str "FAIL-CONTINUE:EXPECTED:" (pr-str (:expected m)))) + (println (str "FAIL-CONTINUE:ACTUAL:" (pr-str (:actual m)))))) (defn- find-line-number [source-file m] (if (instance? Throwable (:actual m)) @@ -44,6 +44,7 @@ (defmethod vim-report :error [m] + (t/inc-report-counter :error) (when-let [source-file (some-> t/*testing-vars* first meta @@ -90,7 +91,8 @@ (when (find-ns 'malli.core) (println "Malli detected. Instrument functions...") (require 'malli.dev) - ((find-var 'malli.dev/start!))) + (require 'malli.dev.pretty) + ((find-var 'malli.dev/start!) {:report ((find-var 'malli.dev.pretty/thrower))})) (let [test-namespaces (->> (all-ns) (mapcat ns-publics) (map (comp meta second)) @@ -101,8 +103,9 @@ (with-redefs [t/report vim-report] (System/exit (if (pos? (if (and -test-file -test-line) - (let [results (t/test-vars [(find-closest-test (.. (java.io.File. -test-file) getAbsolutePath) - (parse-long -test-line))])] + + (let [results (t/run-test-var (find-closest-test (.. (java.io.File. -test-file) getAbsolutePath) + (parse-long -test-line)))] (+ (:fail results 0) (:error results 0))) (reduce (fn [total-fails n] @@ -114,3 +117,6 @@ test-namespaces))) 1 0))))))) + + + -- Gitblit v1.9.3